feat: migrate KeyboardStickyView to reanimated#1307
Draft
kirillzyusko wants to merge 1 commit intomainfrom
Draft
feat: migrate KeyboardStickyView to reanimated#1307kirillzyusko wants to merge 1 commit intomainfrom
KeyboardStickyView to reanimated#1307kirillzyusko wants to merge 1 commit intomainfrom
Conversation
kirillzyusko
added
🐛 bug
Contributor
📊 Package size report
|
kirillzyusko
added
refactor
|
While at it, it would be nice to also allow reanimated shared values for the offset values :) |
Owner
Author
|
@SamuraiF0x what is the use case of having "animated" offset? 🤔 Or why do you want to have padding as a shared value? |
|
@kirillzyusko It’s so I can animate the offset when closed, based on toolbar visibility - the toolbar visibility toggles depending on whether there is content inside input |
kirillzyusko
force-pushed
the
fix/sticky-view-reanimated-again
branch
from
aa0c069 to
d991aa7
Compare
kirillzyusko
force-pushed
the
fix/sticky-view-reanimated-again
branch
from
d991aa7 to
84c320d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #1306 #1273
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist